Feature/add scope to sampling context asgi integration#898
Closed
arturdrozdzyk wants to merge 3 commits into
Closed
Feature/add scope to sampling context asgi integration#898arturdrozdzyk wants to merge 3 commits into
arturdrozdzyk wants to merge 3 commits into
Conversation
added 2 commits
October 27, 2020 17:13
Member
|
I don't know the context of this so I will have to defer. |
Author
|
@rhcarvalho @lobsterkatie can I somehow help with the review? |
untitaker
reviewed
Nov 2, 2020
| traces_sampler=traces_sampler | ||
| ) | ||
|
|
||
| events = capture_events() |
Member
There was a problem hiding this comment.
can you do something with this var, such as asserting the event did/did not get sent?
Member
|
@Lynaj - sorry for the delay. This is actually part of a larger change I was working on, which I just merged: #906. Please let me know if that doesn't serve your needs. (We will do another release in the next few days.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside of the
traces_samplermethod, I need an access to thepath, as well as to themethod. These are stored inside of thescope.It helps me to filter out URLs, that I don't want to include in the performance report.