Skip to content

Remove superfluous calls to RCTConvert #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Remove superfluous calls to RCTConvert #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ios/RNSentry.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ + (NSRegularExpression *)frameRegex {

RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString)
{
[SentryClient setShared:[[SentryClient alloc] initWithDsnString:[RCTConvert NSString:dsnString]]];
[SentryClient setShared:[[SentryClient alloc] initWithDsnString:dsnString]];
[[SentryClient shared] startCrashHandler];
}

Expand Down Expand Up @@ -111,7 +111,7 @@ + (NSRegularExpression *)frameRegex {

RCT_EXPORT_METHOD(captureMessage:(NSString * _Nonnull)message level:(int)level)
{
[[SentryClient shared] captureMessage:[RCTConvert NSString:message] level:level];
[[SentryClient shared] captureMessage:message level:level];
}

RCT_EXPORT_METHOD(setLogLevel:(int)level)
Expand All @@ -121,12 +121,12 @@ + (NSRegularExpression *)frameRegex {

RCT_EXPORT_METHOD(setExtras:(NSDictionary * _Nonnull)extras)
{
[SentryClient shared].extra = [RCTConvert NSDictionary:extras];
[SentryClient shared].extra = extras;
}

RCT_EXPORT_METHOD(setTags:(NSDictionary * _Nonnull)tags)
{
[SentryClient shared].tags = [self sanitizeDictionary:[RCTConvert NSDictionary:tags]];
[SentryClient shared].tags = [self sanitizeDictionary:tags];
}

RCT_EXPORT_METHOD(setUser:(NSDictionary * _Nonnull)user)
Expand Down