chore(ci): Use ubuntu-latest runners everywhere possible #3512

krystofwoldrich · 2024-01-09T20:27:32Z

ONLY CI CHANGES

This PR switches to ubuntu-latest runners everywhere possible, all Android and platform-independent jobs.

macos-latest runners stay only for ios jobs.

Android builds are ~3x faster from ~11 min to ~4 mins.

All android simulators are using ATD images and KVM -> native test from ~8 mins to ~2.

This PR fixes the extra E2E JSC tests on the latest RN that were enabled by mistake.

This PR removes the E2E development builds to lower the number of jobs so the CI is not blocked by the macos runners' smaller pool.

part of Optimize CI #3419

#skip-changelog

github-actions · 2024-01-09T20:39:59Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	422.16 ms	443.94 ms	21.78 ms
Size	17.73 MiB	19.84 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`27ef4ee`	317.40 ms	321.70 ms	4.30 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`6e8584e`	447.10 ms	474.71 ms	27.61 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`457e29f`	398.10 ms	421.39 ms	23.29 ms

App size

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`27ef4ee`	17.73 MiB	19.82 MiB	2.08 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`6e8584e`	17.73 MiB	19.86 MiB	2.12 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`457e29f`	17.73 MiB	19.84 MiB	2.10 MiB

github-actions · 2024-01-09T21:02:59Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	353.64 ms	367.14 ms	13.50 ms
Size	7.15 MiB	8.11 MiB	988.64 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms
`1d86dd6`+dirty	335.76 ms	371.22 ms	35.46 ms
`b1e8712`+dirty	322.55 ms	331.84 ms	9.29 ms
`9433f35`+dirty	265.50 ms	336.08 ms	70.58 ms
`3ffcddd`+dirty	244.82 ms	295.47 ms	50.65 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`575f9da`+dirty	337.15 ms	370.47 ms	33.32 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms

App size

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB
`1d86dd6`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`b1e8712`+dirty	7.15 MiB	8.04 MiB	912.27 KiB
`9433f35`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`3ffcddd`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`575f9da`+dirty	7.15 MiB	8.10 MiB	979.68 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB

github-actions · 2024-01-09T21:12:01Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.08 ms	1224.81 ms	0.73 ms
Size	2.36 MiB	2.88 MiB	525.45 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`1d86dd6`+dirty	1249.71 ms	1279.16 ms	29.45 ms
`d361d38`+dirty	1246.04 ms	1267.12 ms	21.08 ms
`12427f4`+dirty	1267.15 ms	1271.30 ms	4.15 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`22e31b6`+dirty	1253.62 ms	1265.96 ms	12.34 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`1d86dd6`+dirty	2.36 MiB	2.89 MiB	535.43 KiB
`d361d38`+dirty	2.36 MiB	2.85 MiB	499.84 KiB
`12427f4`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`22e31b6`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB

krystofwoldrich · 2024-01-10T10:33:08Z

TODO: Fix sample app node cache

.github/workflows/codegen.yml

.github/workflows/e2e.yml

.github/workflows/sample-application.yml

github-actions · 2024-01-10T13:51:55Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1221.78 ms	1224.04 ms	2.27 ms
Size	2.92 MiB	3.43 MiB	529.84 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`d361d38`+dirty	1272.96 ms	1291.70 ms	18.74 ms
`12427f4`+dirty	1224.90 ms	1231.40 ms	6.50 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`22e31b6`+dirty	1276.55 ms	1278.12 ms	1.57 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`d361d38`+dirty	2.92 MiB	3.41 MiB	503.57 KiB
`12427f4`+dirty	2.92 MiB	3.44 MiB	533.29 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`22e31b6`+dirty	2.92 MiB	3.43 MiB	524.74 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB

lucas-zimerman

🚀🚀🚀

krystofwoldrich added 2 commits January 9, 2024 21:27

chore(ci): Use ubuntu-latest runners everywhere possible

5df4052

Install xcodebeutify only on macos

c792083

krystofwoldrich added 2 commits January 10, 2024 10:33

Run KVM check only for android, use atd image for emulator

abd47b8

exclude dev builds and fix no jsc for 0.73 rn

6c891a0

Add runner os to the sample app node cache

73d9d45

krystofwoldrich marked this pull request as ready for review January 10, 2024 11:17

krystofwoldrich requested a review from lucas-zimerman as a code owner January 10, 2024 11:17

krystofwoldrich added 3 commits January 10, 2024 12:48

remove jsc from e2e test for latest rn

233714f

Use atd device for native tests

97303da

Use gradle cache for all builds

470bafd

krystofwoldrich self-assigned this Jan 10, 2024

github-actions bot reviewed Jan 10, 2024

View reviewed changes

.github/workflows/codegen.yml Show resolved Hide resolved

.github/workflows/e2e.yml Show resolved Hide resolved

.github/workflows/e2e.yml Show resolved Hide resolved

.github/workflows/e2e.yml Show resolved Hide resolved

.github/workflows/sample-application.yml Show resolved Hide resolved

lucas-zimerman approved these changes Jan 10, 2024

View reviewed changes

krystofwoldrich merged commit 1b59214 into main Jan 10, 2024

krystofwoldrich deleted the kw-use-ubuntu-in-e2e-ci branch January 10, 2024 14:18

Uh oh!

chore(ci): Use ubuntu-latest runners everywhere possible #3512

chore(ci): Use ubuntu-latest runners everywhere possible #3512

Uh oh!

Conversation

krystofwoldrich commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Jan 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 10, 2024

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krystofwoldrich commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading