Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Mar 27, 2025

#skip-changelog

Updates the Expo Sample dependencies to the Expo Doctor-recommended versions.

Before:
Screenshot 2025-03-27 at 12 35 18

After:
Screenshot 2025-03-27 at 12 31 39

@krystofwoldrich krystofwoldrich requested review from Copilot and removed request for antonis and lucas-zimerman March 27, 2025 11:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • samples/expo/app.json: Language not supported
  • samples/expo/package.json: Language not supported

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.86 ms 488.94 ms 15.09 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
afe5fcb 322.46 ms 353.04 ms 30.58 ms
d16beca 448.87 ms 447.20 ms -1.67 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
4ed9c54 446.27 ms 433.56 ms -12.71 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
80e955a 440.28 ms 451.68 ms 11.40 ms
52c0562 453.04 ms 434.71 ms -18.33 ms
6fd1d2b 434.04 ms 418.00 ms -16.04 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms

App size

Revision Plain With Sentry Diff
afe5fcb 17.75 MiB 20.11 MiB 2.36 MiB
d16beca 17.74 MiB 20.10 MiB 2.36 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
4ed9c54 17.75 MiB 20.12 MiB 2.37 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
80e955a 17.75 MiB 20.11 MiB 2.37 MiB
52c0562 17.73 MiB 20.11 MiB 2.38 MiB
6fd1d2b 17.75 MiB 20.12 MiB 2.37 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.06 ms 1207.68 ms -17.38 ms
Size 2.63 MiB 3.76 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9282172+dirty 1237.27 ms 1242.20 ms 4.94 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
0ebca77+dirty 1220.75 ms 1222.81 ms 2.06 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
397a69c+dirty 1223.12 ms 1230.37 ms 7.24 ms
255d28b+dirty 1216.78 ms 1218.86 ms 2.08 ms
205982c+dirty 1226.83 ms 1234.36 ms 7.53 ms
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
42438c2+dirty 1216.27 ms 1221.15 ms 4.88 ms
f86dde7+dirty 1204.88 ms 1203.61 ms -1.26 ms

App size

Revision Plain With Sentry Diff
9282172+dirty 2.36 MiB 3.11 MiB 759.89 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
0ebca77+dirty 2.36 MiB 3.04 MiB 698.33 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
397a69c+dirty 2.63 MiB 3.75 MiB 1.12 MiB
255d28b+dirty 2.63 MiB 3.75 MiB 1.12 MiB
205982c+dirty 2.36 MiB 3.11 MiB 760.04 KiB
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
42438c2+dirty 2.63 MiB 3.76 MiB 1.13 MiB
f86dde7+dirty 2.63 MiB 3.75 MiB 1.12 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.14 ms 1227.45 ms 0.31 ms
Size 3.19 MiB 4.33 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9282172+dirty 1227.60 ms 1232.69 ms 5.09 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
0ebca77+dirty 1209.30 ms 1220.33 ms 11.03 ms
728164b+dirty 1280.06 ms 1285.26 ms 5.20 ms
397a69c+dirty 1202.89 ms 1216.53 ms 13.64 ms
255d28b+dirty 1225.18 ms 1222.24 ms -2.94 ms
205982c+dirty 1228.06 ms 1237.72 ms 9.66 ms
c2a4e9b+dirty 1247.39 ms 1243.04 ms -4.35 ms
42438c2+dirty 1218.42 ms 1220.13 ms 1.71 ms
f86dde7+dirty 1219.88 ms 1224.58 ms 4.71 ms

App size

Revision Plain With Sentry Diff
9282172+dirty 2.92 MiB 3.67 MiB 772.46 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
0ebca77+dirty 2.92 MiB 3.61 MiB 705.12 KiB
728164b+dirty 2.92 MiB 3.44 MiB 533.26 KiB
397a69c+dirty 3.19 MiB 4.32 MiB 1.13 MiB
255d28b+dirty 3.19 MiB 4.32 MiB 1.13 MiB
205982c+dirty 2.92 MiB 3.67 MiB 772.63 KiB
c2a4e9b+dirty 2.92 MiB 3.64 MiB 739.91 KiB
42438c2+dirty 3.19 MiB 4.33 MiB 1.14 MiB
f86dde7+dirty 3.19 MiB 4.32 MiB 1.13 MiB

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.02 ms 388.04 ms -3.98 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
60ad48c+dirty 373.40 ms 393.20 ms 19.80 ms
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
e4d9fe0+dirty 368.38 ms 415.44 ms 47.05 ms
ee4aab8+dirty 494.84 ms 574.57 ms 79.73 ms
8b86336+dirty 484.80 ms 537.94 ms 53.14 ms
ddc0552+dirty 405.80 ms 480.00 ms 74.20 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
60ad48c+dirty 7.15 MiB 8.39 MiB 1.23 MiB
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
e4d9fe0+dirty 7.15 MiB 8.38 MiB 1.23 MiB
ee4aab8+dirty 7.15 MiB 8.38 MiB 1.23 MiB
8b86336+dirty 7.15 MiB 8.38 MiB 1.23 MiB
ddc0552+dirty 7.15 MiB 8.37 MiB 1.22 MiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 052071e into main Apr 7, 2025
142 of 144 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-expo-doctor branch April 7, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants