Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Apr 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Temporary PR to run the full CI checks on #4741

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 458.94 ms 447.47 ms -11.47 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ae7b03d 428.82 ms 412.33 ms -16.49 ms
18ce5e8 450.83 ms 436.08 ms -14.75 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
8f0282e 451.19 ms 451.69 ms 0.51 ms
e22745e 462.66 ms 458.10 ms -4.56 ms
a5d86e1 465.06 ms 457.83 ms -7.23 ms
5e5c392 390.42 ms 432.00 ms 41.58 ms
d8992c6 417.72 ms 443.17 ms 25.44 ms
b8ff156 438.80 ms 454.14 ms 15.34 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms

App size

Revision Plain With Sentry Diff
ae7b03d 17.75 MiB 20.11 MiB 2.37 MiB
18ce5e8 17.74 MiB 20.10 MiB 2.36 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
8f0282e 17.75 MiB 20.13 MiB 2.38 MiB
e22745e 17.74 MiB 20.08 MiB 2.34 MiB
a5d86e1 17.74 MiB 20.08 MiB 2.34 MiB
5e5c392 17.75 MiB 20.12 MiB 2.37 MiB
d8992c6 17.75 MiB 20.12 MiB 2.37 MiB
b8ff156 17.74 MiB 20.09 MiB 2.35 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.84 ms 416.52 ms 7.68 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7143e6f+dirty 338.60 ms 374.92 ms 36.32 ms
d56b7dc+dirty 382.04 ms 389.47 ms 7.43 ms
30189be+dirty 362.02 ms 386.80 ms 24.78 ms
5e5c392+dirty 360.23 ms 347.88 ms -12.35 ms
d8992c6+dirty 376.55 ms 393.98 ms 17.43 ms
fc150fe+dirty 409.55 ms 407.37 ms -2.18 ms
025d490+dirty 393.10 ms 402.53 ms 9.43 ms
a0b0298+dirty 424.06 ms 423.76 ms -0.30 ms
e652a2e+dirty 368.83 ms 360.91 ms -7.91 ms
4bec795+dirty 454.02 ms 482.61 ms 28.59 ms

App size

Revision Plain With Sentry Diff
7143e6f+dirty 7.15 MiB 8.38 MiB 1.23 MiB
d56b7dc+dirty 7.15 MiB 8.39 MiB 1.23 MiB
30189be+dirty 7.15 MiB 8.38 MiB 1.23 MiB
5e5c392+dirty 7.15 MiB 8.39 MiB 1.23 MiB
d8992c6+dirty 7.15 MiB 8.39 MiB 1.23 MiB
fc150fe+dirty 7.15 MiB 8.38 MiB 1.23 MiB
025d490+dirty 7.15 MiB 8.39 MiB 1.23 MiB
a0b0298+dirty 7.15 MiB 8.39 MiB 1.23 MiB
e652a2e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
4bec795+dirty 7.15 MiB 8.40 MiB 1.25 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.91 ms 1221.58 ms -0.33 ms
Size 2.63 MiB 3.78 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
18ce5e8+dirty 1247.78 ms 1242.85 ms -4.92 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
1c9e040+dirty 1226.02 ms 1221.06 ms -4.96 ms
7e87527+dirty 1209.85 ms 1216.31 ms 6.46 ms
9672577+dirty 1230.46 ms 1237.43 ms 6.97 ms
60ad48c+dirty 1214.22 ms 1227.41 ms 13.19 ms
6a667d6+dirty 1209.23 ms 1210.85 ms 1.62 ms
7bc4d75+dirty 1233.40 ms 1229.56 ms -3.83 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
18ce5e8+dirty 2.36 MiB 3.12 MiB 778.65 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
1c9e040+dirty 2.63 MiB 3.69 MiB 1.06 MiB
7e87527+dirty 2.63 MiB 3.69 MiB 1.05 MiB
9672577+dirty 2.63 MiB 3.70 MiB 1.06 MiB
60ad48c+dirty 2.63 MiB 3.75 MiB 1.12 MiB
6a667d6+dirty 2.63 MiB 3.70 MiB 1.06 MiB
7bc4d75+dirty 2.36 MiB 3.10 MiB 752.58 KiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.90 ms 1232.30 ms 8.40 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
18ce5e8+dirty 1244.67 ms 1242.96 ms -1.72 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
1c9e040+dirty 1214.84 ms 1222.06 ms 7.22 ms
7e87527+dirty 1223.83 ms 1222.90 ms -0.94 ms
9672577+dirty 1215.21 ms 1214.08 ms -1.13 ms
60ad48c+dirty 1225.79 ms 1233.51 ms 7.72 ms
6a667d6+dirty 1233.27 ms 1235.16 ms 1.89 ms
7bc4d75+dirty 1222.13 ms 1216.39 ms -5.74 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
18ce5e8+dirty 2.92 MiB 3.69 MiB 789.94 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
1c9e040+dirty 3.19 MiB 4.25 MiB 1.07 MiB
7e87527+dirty 3.19 MiB 4.25 MiB 1.06 MiB
9672577+dirty 3.19 MiB 4.26 MiB 1.08 MiB
60ad48c+dirty 3.19 MiB 4.32 MiB 1.13 MiB
6a667d6+dirty 3.19 MiB 4.26 MiB 1.08 MiB
7bc4d75+dirty 2.92 MiB 3.66 MiB 757.15 KiB

@antonis
Copy link
Contributor Author

antonis commented Apr 11, 2025

Closing since all (74) checks have passed 🎉

@antonis antonis closed this Apr 11, 2025
@antonis antonis deleted the antonis/trivik-patch1 branch April 11, 2025 10:08
@antonis antonis mentioned this pull request Apr 11, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants