Skip to content

chore(ci): Fix update-deps failure #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 15, 2025
Merged

chore(ci): Fix update-deps failure #4749

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
38214b6
Enable corepack after instalation
antonis Apr 15, 2025
65ef417
Temp: enable on PRs for testing
antonis Apr 15, 2025
82e6e97
Enable corepack
antonis Apr 15, 2025
61b5c6c
Test with enable corepack
antonis Apr 15, 2025
73241b1
Revert "Test with enable corepack"
antonis Apr 15, 2025
e994406
Revert "Enable corepack"
antonis Apr 15, 2025
a1f8b61
Only enable in update-package
antonis Apr 15, 2025
f445df7
Print corepack version
antonis Apr 15, 2025
70161e8
do not install globally
antonis Apr 15, 2025
e0d12ef
Just enable corepack in update-package-json.sh script
antonis Apr 15, 2025
1a8d2d5
Revert "Temp: enable on PRs for testing"
antonis Apr 15, 2025
51ac355
Add comment explaining the revert and future steps
antonis Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/update-package-json.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# expects `$repo`, `$tagPrefix` and `$packages` (array) variables to be defined, see e.g. update-javascript.sh

npm i -g corepack # This repository uses Yarn v3 which requires corepack to be installed
# Since Corepack is not going to be distributed with Node.js v25+ in the future we need to install Corepack globally.
# See: https://github.com/getsentry/sentry-react-native/pull/4741
corepack enable # This repository uses Yarn v3 which requires corepack to be enabled
Copy link
Contributor

@krystofwoldrich krystofwoldrich Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment with a brief explanation that this will need to be fixed in the future and why and link to the original PR.

Copy link
Contributor Author

@antonis antonis Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea Krystof 👍
Added a comment with 51ac355


monorepoRoot="$(dirname "$0")/.."

Expand Down
Loading