-
-
Notifications
You must be signed in to change notification settings - Fork 354
fix(sec): Reduct sensitive data from Maestro logs #4872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sec): Reduct sensitive data from Maestro logs #4872
Conversation
iOS (new) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
|
I didn't notice any user secrets in on the actions but at the same time I haven't seen your action running. |
iOS (legacy) Performance metrics 🚀
|
This reverts commit f9c7f70.
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say with the ci test you did, it's enough validation for it to be approved without depending on a real secret validation.
Thank you for suggesting this approach for testing on CI @lucas-zimerman 🙇 |
Android (legacy) Performance metrics 🚀
|
|
Thank you for fixing this so quickly! |
…ps://github.com/getsentry/sentry-react-native into antonis/reduct-sensitive-data-from-maestro-logs
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
📢 Type of change
📜 Description
Reduct sensitive data from Maestro logs.
Other considered approaches:
defineVariablesCommand.envsection which shows all resolved environment variables. ❌💡 Motivation and Context
Sensitive data from Maestro logs
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog