Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 29, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Reduct sensitive data from Maestro logs.

Other considered approaches:

💡 Motivation and Context

Sensitive data from Maestro logs

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis marked this pull request as ready for review May 29, 2025 15:28
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.29 ms 1209.96 ms -1.34 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.10 ms 395.96 ms -5.14 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

@lucas-zimerman
Copy link
Collaborator

I didn't notice any user secrets in on the actions but at the same time I haven't seen your action running.

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.24 ms 1239.02 ms 17.78 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say with the ci test you did, it's enough validation for it to be approved without depending on a real secret validation.

@antonis
Copy link
Contributor Author

antonis commented May 30, 2025

I'd say with the ci test you did, it's enough validation for it to be approved without depending on a real secret validation.

Thank you for suggesting this approach for testing on CI @lucas-zimerman 🙇
I agree that this should validate that the secret won't leak in the maestro logs.
I'll wait for a real secret to be deployed to make sure all tests are green before merging.

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 467.80 ms 451.31 ms -16.49 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

@krystofwoldrich
Copy link
Contributor

Thank you for fixing this so quickly!

Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 43460ef into main Jun 2, 2025
53 of 65 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/reduct-sensitive-data-from-maestro-logs branch June 2, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants