fix(e2e): Remove auth token from launch params #4876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49ea1eb | 419.33 ms | 447.61 ms | 28.28 ms |
| 87dd218 | 438.14 ms | 460.09 ms | 21.95 ms |
| bfbb0a1 | 433.94 ms | 453.51 ms | 19.57 ms |
| ee4aab8 | 418.63 ms | 435.63 ms | 17.01 ms |
| 5852d77 | 415.81 ms | 421.02 ms | 5.21 ms |
| 8bda0cc | 450.38 ms | 433.89 ms | -16.49 ms |
| 5571a20 | 410.55 ms | 441.06 ms | 30.51 ms |
| 7fd512a | 442.18 ms | 437.57 ms | -4.61 ms |
| f54118b | 441.24 ms | 431.92 ms | -9.32 ms |
| 27ef4ee | 317.40 ms | 321.70 ms | 4.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49ea1eb | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 87dd218 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| bfbb0a1 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ee4aab8 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 5852d77 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 8bda0cc | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 5571a20 | 17.73 MiB | 19.93 MiB | 2.19 MiB |
| 7fd512a | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| f54118b | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| 27ef4ee | 17.73 MiB | 19.82 MiB | 2.08 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6695a+dirty | 1224.12 ms | 1226.10 ms | 1.98 ms |
| 05b43ab+dirty | 1225.33 ms | 1227.33 ms | 2.00 ms |
| d56b7dc+dirty | 1225.20 ms | 1233.59 ms | 8.39 ms |
| 488c9c5+dirty | 1209.36 ms | 1224.18 ms | 14.82 ms |
| 7fd512a+dirty | 1218.78 ms | 1217.25 ms | -1.53 ms |
| d16beca+dirty | 1215.94 ms | 1228.20 ms | 12.27 ms |
| 5a22220+dirty | 1209.49 ms | 1220.94 ms | 11.45 ms |
| b677956+dirty | 1221.47 ms | 1217.90 ms | -3.57 ms |
| c314a21+dirty | 1206.74 ms | 1220.06 ms | 13.32 ms |
| c398f67+dirty | 1219.67 ms | 1225.66 ms | 5.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6695a+dirty | 2.63 MiB | 3.79 MiB | 1.16 MiB |
| 05b43ab+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| d56b7dc+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 488c9c5+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 7fd512a+dirty | 2.36 MiB | 3.10 MiB | 753.35 KiB |
| d16beca+dirty | 2.36 MiB | 3.12 MiB | 779.39 KiB |
| 5a22220+dirty | 2.36 MiB | 2.92 MiB | 570.21 KiB |
| b677956+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| c314a21+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| c398f67+dirty | 2.36 MiB | 3.04 MiB | 696.27 KiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49ea1eb+dirty | 393.09 ms | 404.74 ms | 11.65 ms |
| c314a21+dirty | 419.41 ms | 426.02 ms | 6.61 ms |
| ee4aab8+dirty | 494.84 ms | 574.57 ms | 79.73 ms |
| e540498+dirty | 408.56 ms | 480.00 ms | 71.44 ms |
| c10f417+dirty | 383.91 ms | 368.96 ms | -14.96 ms |
| 60d7316+dirty | 475.43 ms | 535.26 ms | 59.84 ms |
| b6da94a+dirty | 371.63 ms | 373.76 ms | 2.12 ms |
| d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
| 9385d74+dirty | 381.56 ms | 416.02 ms | 34.46 ms |
| 0c32605+dirty | 404.08 ms | 412.82 ms | 8.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49ea1eb+dirty | 7.15 MiB | 8.40 MiB | 1.24 MiB |
| c314a21+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| ee4aab8+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| e540498+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| c10f417+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 60d7316+dirty | 7.15 MiB | 8.38 MiB | 1.22 MiB |
| b6da94a+dirty | 7.15 MiB | 8.40 MiB | 1.24 MiB |
| d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
| 9385d74+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 0c32605+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6695a+dirty | 1209.65 ms | 1216.66 ms | 7.01 ms |
| 05b43ab+dirty | 1231.12 ms | 1235.83 ms | 4.70 ms |
| d56b7dc+dirty | 1211.17 ms | 1224.25 ms | 13.08 ms |
| 488c9c5+dirty | 1225.71 ms | 1222.00 ms | -3.71 ms |
| 7fd512a+dirty | 1239.41 ms | 1241.50 ms | 2.09 ms |
| d16beca+dirty | 1239.00 ms | 1233.89 ms | -5.11 ms |
| 5a22220+dirty | 1246.18 ms | 1249.61 ms | 3.43 ms |
| b677956+dirty | 1224.30 ms | 1239.53 ms | 15.23 ms |
| c314a21+dirty | 1225.67 ms | 1237.90 ms | 12.22 ms |
| c398f67+dirty | 1227.31 ms | 1230.00 ms | 2.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6695a+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 05b43ab+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
| d56b7dc+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 488c9c5+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 7fd512a+dirty | 2.92 MiB | 3.66 MiB | 758.62 KiB |
| d16beca+dirty | 2.92 MiB | 3.69 MiB | 790.48 KiB |
| 5a22220+dirty | 2.92 MiB | 3.48 MiB | 575.81 KiB |
| b677956+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| c314a21+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| c398f67+dirty | 2.92 MiB | 3.60 MiB | 701.89 KiB |
antonis
approved these changes
Jun 2, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Thank you for looking into this @krystofwoldrich 🙇
I've tested locally and the token still leaks in the commands-*.json files.
"command" : {
"defineVariablesCommand" : {
"env" : {
"APP_ID" : "org.reactjs.native.example.RnDiffApp",
"SENTRY_AUTH_TOKEN" : "redacted-token-string"
},
"optional" : false
}
},
My understanding is that this leaks when passing the token in the Maestro cli command. but I haven't found a way to avoid this other than redacting after the tests.
Removing the auth token from the launch parameters does not affect the test results and it makes sense to remove them 👍
Contributor
Author
|
@antonis Thank you for testing this. And catching that the token is still in the |
krystofwoldrich
added a commit
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Remove unused token launch param from RN E2E tests.
#skip-changelog