Skip to content

Move sentry-cocoa enableLogs out of experimental #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: itay/fix_sentreyscreenframes
Choose a base branch
from
Draft

Move sentry-cocoa enableLogs out of experimental #5267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7577a17
Use non-experimental enableLogs
denrase Oct 14, 2025
d3fe306
bump target
denrase Oct 14, 2025
3bd04c2
remove enable tracing
denrase Oct 14, 2025
cc596a8
Update enableLogs tests
denrase Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,14 @@
inputFileListPaths = (
"${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources-${CONFIGURATION}-input-files.xcfilelist",
);
inputPaths = (
);
name = "[CP] Copy Pods Resources";
outputFileListPaths = (
"${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources-${CONFIGURATION}-output-files.xcfilelist",
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources.sh\"\n";
Expand Down Expand Up @@ -434,7 +438,7 @@
"\"$(PODS_TARGET_SRCROOT)/include/\"",
"\"${PODS_ROOT}/Sentry/Sources/Sentry/include\"",
);
IPHONEOS_DEPLOYMENT_TARGET = 12.4;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.sentry.RNSentryCocoaTesterTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -501,7 +505,7 @@
"\"$(PODS_TARGET_SRCROOT)/include/\"",
"\"${PODS_ROOT}/Sentry/Sources/Sentry/include\"",
);
IPHONEOS_DEPLOYMENT_TARGET = 12.4;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.sentry.RNSentryCocoaTesterTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
13 changes: 3 additions & 10 deletions packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ - (void)testCreateOptionsWithDictionaryRemovesPerformanceProperties
XCTAssertEqual(
actualOptions.tracesSampleRate, nil, @"Traces sample rate should not be passed to native");
XCTAssertEqual(actualOptions.tracesSampler, nil, @"Traces sampler should not be passed to native");
XCTAssertEqual(actualOptions.enableTracing, false, @"EnableTracing should not be passed to native");
}

- (void)testCaptureFailedRequestsIsDisabled
Expand Down Expand Up @@ -331,10 +330,7 @@ - (void)testCreateOptionsWithDictionaryEnableLogsEnabled
XCTAssertNotNil(actualOptions, @"Did not create sentry options");
XCTAssertNil(error, @"Should not pass no error");

id experimentalOptions = [actualOptions valueForKey:@"experimental"];
XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil");

BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue];
BOOL enableLogs = [[actualOptions valueForKey:@"enableLogs"] boolValue];
XCTAssertTrue(enableLogs, @"enableLogs should be enabled");
}

Expand All @@ -352,11 +348,8 @@ - (void)testCreateOptionsWithDictionaryEnableLogsDisabled

XCTAssertNotNil(actualOptions, @"Did not create sentry options");
XCTAssertNil(error, @"Should not pass no error");

id experimentalOptions = [actualOptions valueForKey:@"experimental"];
XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil");

BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue];

BOOL enableLogs = [[actualOptions valueForKey:@"enableLogs"] boolValue];
XCTAssertFalse(enableLogs, @"enableLogs should be disabled");
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/ios/RNSentryExperimentalOptions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
if (sentryOptions == nil) {
return;
}
sentryOptions.experimental.enableLogs = enabled;
sentryOptions.enableLogs = enabled;

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy macos dev no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy macos production no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy ios dev no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build ios production no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build new ios production no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build new ios dev no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build ios dev no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy ios dev dynamic-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build ios dev dynamic-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy ios production no-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build legacy ios production dynamic-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'

Check failure on line 27 in packages/core/ios/RNSentryExperimentalOptions.m

View workflow job for this annotation

GitHub Actions / Build ios production dynamic-frameworks 

property 'enableLogs' not found on object of type 'SentryOptions *'
}

@end
Loading