Move sentry-cocoa enableLogs out of experimental
#5267
Draft
+10
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Move `sentry-cocoa` `enableLogs` out of experimental ([#5267](https://github.com/getsentry/sentry-react-native/pull/5267))If none of the above apply, you can opt out of this check by adding |
denrase
changed the title
senry-cocoa enableLogs out of experimental
denrase
changed the title
senry-cocoa enableLogs out of experimentalsentry-cocoa enableLogs out of experimental
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ede2a89 | 414.58 ms | 395.16 ms | -19.42 ms |
| 3a9200e+dirty | 451.42 ms | 481.13 ms | 29.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ede2a89 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 3a9200e+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a9200e+dirty | 341.91 ms | 405.08 ms | 63.17 ms |
| ede2a89+dirty | 398.04 ms | 486.04 ms | 88.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a9200e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| ede2a89+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
senry-cocoaenableLogsout of experimental💡 Motivation and Context
Branches from #5153 so coco CI is happy.
Relates to getsentry/sentry-cocoa#6359
This can only be merged once #5153 is merged and
sentry-cocoav9 is released.💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps