Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Dec 2, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5419 to avoid any conflicts and test as a whole

📜 Description

Add frame data to all spans created through API

💡 Motivation and Context

Fixes #4933

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Dec 2, 2025

@sentry review

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.59 ms 421.66 ms 15.07 ms
Size 43.75 MiB 48.05 MiB 4.30 MiB

@antonis antonis marked this pull request as ready for review December 2, 2025 14:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 361.00 ms 384.16 ms 23.16 ms
Size 43.94 MiB 48.88 MiB 4.94 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.30 ms 1217.12 ms 2.83 ms
Size 3.41 MiB 4.60 MiB 1.18 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.32 ms 1232.44 ms -1.88 ms
Size 3.41 MiB 4.60 MiB 1.18 MiB

Baseline results on branch: antonis/ttid-ttfd-frames

Startup times

Revision Plain With Sentry Diff
a272751+dirty 1215.15 ms 1207.33 ms -7.81 ms

App size

Revision Plain With Sentry Diff
a272751+dirty 3.41 MiB 4.60 MiB 1.18 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants