-
-
Notifications
You must be signed in to change notification settings - Fork 357
chore(changelog): Add upgrade notice in the changelog #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
|
|
||
| Version 8 of the Sentry React Native SDK updates the underlying native SDKs (Cocoa v9, CLI v3, Android Gradle Plugin v6) which introduce breaking changes in minimum version requirements and build tooling. | ||
|
|
||
| See our [migration docs](https://docs.sentry.io/platforms/react-native/migration/v7-to-v8/) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new doc is not available yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added doc with getsentry/sentry-docs#16203
|
|
||
| - **Android**: ([#5578](https://github.com/getsentry/sentry-react-native/pull/5578)) | ||
| - Sentry Android Gradle Plugin **6.0.0** (previously 5.x) | ||
| - Android Gradle Plugin **7.4.0+** (previously 7.3.0+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: is this a break change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is since if an React Native project was using an older AGP version and bumps to SDK v8 their build will break with an incompatibility error unless they also upgrade to AGP 7.4.0+
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Thank you for the update!
|
|
||
| ## Unreleased | ||
|
|
||
| ### Upgrading from 7.x to 8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Small nit, might be worth changing line 5 from 7.x to 8.0 and 6.x to 7.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @lucas-zimerman
updated with 64a65ba
📢 Type of change
Based on: #5501
📜 Description
Add upgrade notice in the changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog