Fix missing keys in Android event context #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
May 15, 2017
| } | ||
|
|
||
| helper.helpBuildingEvent(eventBuilder); | ||
|
|
Member
There was a problem hiding this comment.
Can you also add a check for extra?
Amwam
force-pushed
the
feature/fix-android
branch
from
7ad5f58 to
d9be263
Compare
Member
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors running on Android. The keys for 'user' and 'tags' weren't defined (at least at startup time), so I've wrapped their access in a check.
I wasn't sure if they should be defined at this point in time, I'd be happy to change this PR, if you could point me in the right direction