chore(deps): bump eslint from 8.x to 9.x by antonis · Pull Request #5827 · getsentry/sentry-react-native

antonis · 2026-03-16T16:03:50Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Upgrades ESLint from v8 to v9 (latest 9.39.4) across all workspaces. This is based on the dependabot PR #5594 but reworked to handle the breaking changes properly.

Note that we applied ESLINT_USE_FLAT_CONFIG=false to avoid major refactoring.

💡 Motivation and Context

ESLint 8 is deprecated and no longer receiving updates. ESLint 9 brings performance improvements and is required for newer plugin versions.

Fixes #5600

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Close chore(deps-dev): bump eslint from 8.57.1 to 9.26.0 #5594 after merging this PR
Bump to ESLint 10 (which is pretty new) or OXLint

#skip-changelog

github-actions · 2026-03-16T16:04:12Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/core/src/js/integrations/debugsymbolicator.ts

Upgrade ESLint from v8 to v9 across all workspaces. ESLint 9 uses flat config by default, but we keep using legacy .eslintrc.js format via ESLINT_USE_FLAT_CONFIG=false since upstream @sentry-internal/eslint-config-sdk hasn't migrated yet. Key changes: - Bump eslint to ^9.0.0 in all packages - Bump @typescript-eslint/* to ^8.0.0 (supports ESLint 9) - Bump @react-native/eslint-config to 0.84.1 (ESLint 9 compatible deps) - Replace deprecated @typescript-eslint/ban-types with new v8 rules - Replace @typescript-eslint/no-var-requires with no-require-imports - Set caughtErrors: 'none' for no-unused-vars (v8 changed default) - Set no-explicit-any to 'warn' (was 'warn' in v5, 'error' in v8) - Add ESLINT_USE_FLAT_CONFIG=false to lint/fix scripts - Auto-fix prefer-optional-chain violations - Force eslint-plugin-ft-flow to ^3.0.0 via resolution (ESLint 9 compat) Fixes #5600 Ref: #5594 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

lucas-zimerman · 2026-03-17T12:12:51Z

There are 42 lint errors when testing the PR locally, we should address them before merging.

packages/core/.eslintrc.js

lucas-zimerman · 2026-03-17T12:24:55Z

Thank you for the PR! ~~the only issue we need to fix is the linter before merging.~~

lint errors due to outdated packages locally

antonis · 2026-03-17T13:08:19Z

There are 42 lint errors when testing the PR locally, we should address them before merging.

Can you provide the errors if possible. It runs cleanly on my machine 😅 apart from some obcj c formatting that unrelated to this PR

antonis · 2026-03-17T13:08:57Z

lint errors due to outdated packages locally

Ignore the above then :)

github-actions · 2026-03-17T13:39:33Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1203.61 ms	1198.70 ms	-4.91 ms
Size	3.38 MiB	4.72 MiB	1.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-03-17T14:54:06Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	414.44 ms	442.56 ms	28.12 ms
Size	43.75 MiB	48.32 MiB	4.57 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	406.62 ms	400.58 ms	-6.04 ms
`df1f7df`+dirty	442.64 ms	427.16 ms	-15.48 ms
`a483f9f`+dirty	396.82 ms	453.28 ms	56.46 ms
`60cd796`+dirty	445.84 ms	492.45 ms	46.61 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms
`80e4616`+dirty	411.58 ms	462.12 ms	50.54 ms
`55b77fc`+dirty	411.87 ms	417.16 ms	5.29 ms
`bca62c0`+dirty	414.36 ms	451.06 ms	36.70 ms
`0b64753`+dirty	448.67 ms	474.61 ms	25.94 ms
`4e6d7d7`+dirty	480.73 ms	515.73 ms	35.00 ms

App size

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`df1f7df`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`a483f9f`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`60cd796`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`80e4616`+dirty	43.75 MiB	48.55 MiB	4.80 MiB
`55b77fc`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`bca62c0`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`0b64753`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`4e6d7d7`+dirty	43.75 MiB	48.40 MiB	4.64 MiB

github-actions · 2026-03-17T14:56:44Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1205.39 ms	1218.85 ms	13.46 ms
Size	3.38 MiB	4.72 MiB	1.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`bef3709`+dirty	1217.79 ms	1225.33 ms	7.54 ms
`a206511`+dirty	1225.02 ms	1223.74 ms	-1.28 ms
`74979ac`+dirty	1212.33 ms	1212.54 ms	0.21 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`8a868fe`+dirty	1206.85 ms	1215.04 ms	8.19 ms
`d590428`+dirty	1221.23 ms	1225.27 ms	4.03 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-03-17T15:12:39Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	407.30 ms	425.78 ms	18.48 ms
Size	43.94 MiB	49.18 MiB	5.24 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70250df`+dirty	418.08 ms	480.84 ms	62.76 ms
`8d89cc9`+dirty	357.69 ms	415.79 ms	58.10 ms
`1853710`+dirty	360.67 ms	396.28 ms	35.61 ms
`55b77fc`+dirty	410.46 ms	414.11 ms	3.65 ms
`69602ce`+dirty	375.37 ms	405.28 ms	29.91 ms
`c1573b3`+dirty	355.65 ms	448.82 ms	93.17 ms
`90afdd3`+dirty	367.79 ms	404.84 ms	37.05 ms
`955f2eb`+dirty	388.13 ms	433.56 ms	45.44 ms
`80e4616`+dirty	427.31 ms	461.15 ms	33.84 ms
`276d348`+dirty	356.30 ms	405.27 ms	48.97 ms

App size

Revision	Plain	With Sentry	Diff
`70250df`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`8d89cc9`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`1853710`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`55b77fc`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`69602ce`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c1573b3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`90afdd3`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`955f2eb`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`80e4616`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`276d348`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

lucas-zimerman

LGTM!

antonis force-pushed the chore/bump-eslint-9 branch 2 times, most recently from ef95327 to 61a13a2 Compare March 17, 2026 10:42

antonis marked this pull request as ready for review March 17, 2026 10:52

antonis requested review from alwx and lucas-zimerman as code owners March 17, 2026 10:52

cursor bot reviewed Mar 17, 2026

View reviewed changes

packages/core/src/js/integrations/debugsymbolicator.ts Outdated Show resolved Hide resolved

antonis force-pushed the chore/bump-eslint-9 branch from 61a13a2 to 289eff5 Compare March 17, 2026 11:37

lucas-zimerman reviewed Mar 17, 2026

View reviewed changes

packages/core/.eslintrc.js Show resolved Hide resolved

lucas-zimerman added the skip-changelog label Mar 17, 2026

lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Mar 17, 2026

antonis requested a review from lucas-zimerman March 17, 2026 14:47

lucas-zimerman approved these changes Mar 17, 2026

View reviewed changes

antonis merged commit cf8636c into main Mar 17, 2026
169 of 200 checks passed

antonis deleted the chore/bump-eslint-9 branch March 17, 2026 15:21

antonis mentioned this pull request Mar 17, 2026

chore(deps-dev): bump eslint from 8.57.1 to 9.26.0 #5594

Closed

Uh oh!

Conversation

antonis commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucas-zimerman commented Mar 17, 2026

Uh oh!

Uh oh!

lucas-zimerman commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis commented Mar 17, 2026

Uh oh!

antonis commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 17, 2026

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 17, 2026

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 17, 2026

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Mar 16, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading

lucas-zimerman commented Mar 17, 2026 •

edited

Loading