fix(android): Mask auth token in sentry.gradle upload-task log#6057
Merged
fix(android): Mask auth token in sentry.gradle upload-task log#6057
Conversation
The upload task logged its full sentry-cli argument list at the gradle lifecycle log level, which is the default verbosity. When flavorAware is enabled the args include `--auth-token <token>`, exposing it in CI build logs and developer terminal scrollback. Replace the token value with `***` in the logged copy of the args; the actual command-line invocation is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
antonis
commented
Apr 28, 2026
alwx
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
sentry-react-nativeupload task insentry.gradlewas logging its full sentry-cli argument list at the Gradle lifecycle log level (default verbosity). WhenflavorAwareis enabled, those args include the auth token. Replace the token's value with***in the logged copy; the actual command-line invocation is unchanged.The masking is value-based via
args.collect { it == sentryAuthToken ? "***" : it }, so the token is redacted wherever it appears in the args list. A short comment notes thatloggedArgsmust not be passed to the CLI.Motivation and Context
Internal security review.
How did you test it?
--url,--bundle,--sourcemap,--org,--project,--release,--dist,extraArgs) — only--auth-tokencarries a secret.***appears next to--auth-token.Checklist
sendDefaultPIIis enabledNext steps
None.