Skip to content

Locally vendor sentry_formatHexAddress* helpers#6112

Merged
alwx merged 2 commits intomainfrom
fix/alwx/locally-vendored-headers
May 7, 2026
Merged

Locally vendor sentry_formatHexAddress* helpers#6112
alwx merged 2 commits intomainfrom
fix/alwx/locally-vendored-headers

Conversation

@alwx
Copy link
Copy Markdown
Contributor

@alwx alwx commented May 7, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

We need to vendor sentry_formatHexAddress* helpers to get rid of SentryFormatter.h dependency and removing ${PODS_ROOT}/Sentry/Sources/Sentry... paths from HEADER_SEARCH_PATHS. That's a prerequisite for consuming sentry-cocoa as an xcframework or via SPM binaryTarget.

What's in SentryFormatter.h is basically a copy-paste from https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Sentry/include/SentryFormatter.h

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@alwx alwx self-assigned this May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label May 7, 2026
Copy link
Copy Markdown
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Added the ready-to-merge label to run the native compiles/checks before we ⏳

@sentry
Copy link
Copy Markdown

sentry Bot commented May 7, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.11.0 (87) Release

⚙️ sentry-react-native Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3818.73 ms 1209.89 ms -2608.84 ms
Size 5.15 MiB 6.67 MiB 1.51 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5fe1c6c+dirty 1220.79 ms 1217.63 ms -3.16 ms
7ac3378+dirty 1213.37 ms 1218.15 ms 4.78 ms
890d145+dirty 1223.59 ms 1231.37 ms 7.78 ms
3817909+dirty 1183.90 ms 1187.50 ms 3.60 ms
bc0d8cf+dirty 3830.33 ms 1220.52 ms -2609.81 ms
7d6fd3a+dirty 1223.29 ms 1229.57 ms 6.28 ms
3ce5254+dirty 1219.93 ms 1221.90 ms 1.96 ms
04207c4+dirty 1191.27 ms 1189.78 ms -1.48 ms
0d9949d+dirty 1211.38 ms 1219.67 ms 8.29 ms
5c1e987+dirty 1204.30 ms 1222.15 ms 17.85 ms

App size

Revision Plain With Sentry Diff
5fe1c6c+dirty 3.38 MiB 4.77 MiB 1.39 MiB
7ac3378+dirty 3.38 MiB 4.76 MiB 1.38 MiB
890d145+dirty 3.38 MiB 4.77 MiB 1.38 MiB
3817909+dirty 3.38 MiB 4.73 MiB 1.35 MiB
bc0d8cf+dirty 5.15 MiB 6.67 MiB 1.51 MiB
7d6fd3a+dirty 3.38 MiB 4.77 MiB 1.39 MiB
3ce5254+dirty 3.38 MiB 4.76 MiB 1.38 MiB
04207c4+dirty 3.38 MiB 4.76 MiB 1.38 MiB
0d9949d+dirty 3.38 MiB 4.76 MiB 1.38 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3851.42 ms 1225.16 ms -2626.26 ms
Size 5.15 MiB 6.67 MiB 1.51 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5fe1c6c+dirty 1201.36 ms 1209.15 ms 7.78 ms
7ac3378+dirty 1202.35 ms 1198.31 ms -4.04 ms
890d145+dirty 1212.98 ms 1220.10 ms 7.12 ms
3817909+dirty 1210.76 ms 1215.64 ms 4.89 ms
bc0d8cf+dirty 3834.64 ms 1223.91 ms -2610.73 ms
7d6fd3a+dirty 1210.89 ms 1217.63 ms 6.74 ms
3ce5254+dirty 1217.70 ms 1224.69 ms 6.99 ms
04207c4+dirty 1228.55 ms 1226.04 ms -2.51 ms
0d9949d+dirty 1203.94 ms 1202.27 ms -1.67 ms
5c1e987+dirty 1208.43 ms 1220.72 ms 12.29 ms

App size

Revision Plain With Sentry Diff
5fe1c6c+dirty 3.38 MiB 4.77 MiB 1.39 MiB
7ac3378+dirty 3.38 MiB 4.76 MiB 1.38 MiB
890d145+dirty 3.38 MiB 4.77 MiB 1.38 MiB
3817909+dirty 3.38 MiB 4.73 MiB 1.35 MiB
bc0d8cf+dirty 5.15 MiB 6.67 MiB 1.51 MiB
7d6fd3a+dirty 3.38 MiB 4.77 MiB 1.39 MiB
3ce5254+dirty 3.38 MiB 4.76 MiB 1.38 MiB
04207c4+dirty 3.38 MiB 4.76 MiB 1.38 MiB
0d9949d+dirty 3.38 MiB 4.76 MiB 1.38 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB

@alwx alwx merged commit 3d0c938 into main May 7, 2026
114 of 119 checks passed
@alwx alwx deleted the fix/alwx/locally-vendored-headers branch May 7, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants