Skip to content

Filter ExceptionsManager.reportException duplicates in app-start init#6145

Merged
alwx merged 4 commits into
mainfrom
alwx/fixes/duplicate-js-error-app-start-init
May 13, 2026
Merged

Filter ExceptionsManager.reportException duplicates in app-start init#6145
alwx merged 4 commits into
mainfrom
alwx/fixes/duplicate-js-error-app-start-init

Conversation

@alwx
Copy link
Copy Markdown
Contributor

@alwx alwx commented May 13, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #6116

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Filter ExceptionsManager.reportException duplicates in app-start init by alwx in #6145
  • chore(deps): update JavaScript SDK to v10.53.1 by github-actions in #6139
  • feat(core): Enable autoInjectSentryLabel by default in Metro config by antonis in #6141
  • feat(core): Respect Mask boundaries when reading sentry-label by antonis in #6142
  • fix(android): Handle boolean values in JSON options converter by antonis in #6130
  • Multi-instance <TimeToInitialDisplay> / <TimeToFullDisplay> coordination; a multi-signal TTID/TTFD system by alwx in #6090
  • chore(deps): update Bundler Plugins to v5.3.0 by github-actions in #6138
  • chore: Merge 8.11.1 back to main by antonis in #6135
  • chore: Update warning regarding iOS crash in sentry-cocoa 9.12.0 by antonis in #6136
  • chore(deps): update CLI to v3.4.2 by github-actions in #6129
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.26.2 to 2.26.3 by dependabot in #6126
  • chore(deps): bump getsentry/craft from 2.26.2 to 2.26.3 by dependabot in #6127
  • chore(deps): bump github/codeql-action from 4.35.3 to 4.35.4 by dependabot in #6128
  • feat(core): Extract text from children of touched components for breadcrumb labels by antonis in #6106
  • chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.25.0 to 7.29.4 by dependabot in #6124
  • chore(deps): bump fast-uri from 3.0.1 to 3.1.2 by dependabot in #6121
  • chore(deps): bump fast-xml-builder from 1.1.5 to 1.2.0 by dependabot in #6120
  • chore(deps): bump socks to ^2.8.8 to fix ip-address vulnerability by antonis in #6117
  • chore(deps): bump uuid to ^13.0.1 to fix buffer bounds check vulnerability by antonis in #6118
  • test(replay): Add passthrough tests for device-state replay breadcrumbs by antonis in #6115
  • chore(deps): update JavaScript SDK to v10.52.0 by github-actions in #6108
  • chore(deps): bump basic-ftp from 5.3.0 to 5.3.1 by dependabot in #6111

🤖 This preview updates automatically when you update the PR.

@alwx alwx marked this pull request as ready for review May 13, 2026 09:08
@antonis antonis added the ready-to-merge Triggers the full CI test suite label May 13, 2026
Copy link
Copy Markdown
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog issue LGTM to merge and fixes the issue 🚀
I've also added the ready-to-merge label to run the native tests.

A suggested improvement could be extracting the full logic of RNSentry.mm including the ignoreErrorPatterns in a helper to avoid duplication and add tests for it. I think this can be part of a follow up PR though.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3833.67 ms 1220.19 ms -2613.48 ms
Size 5.15 MiB 6.68 MiB 1.53 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc0d8cf+dirty 3830.33 ms 1220.52 ms -2609.81 ms
7d6fd3a+dirty 1223.29 ms 1229.57 ms 6.28 ms
df5d108+dirty 1225.90 ms 1220.14 ms -5.76 ms
5fe1c6c+dirty 1220.79 ms 1217.63 ms -3.16 ms
4e0ba9c+dirty 3839.22 ms 1221.06 ms -2618.16 ms
2c735cc+dirty 1229.67 ms 1221.50 ms -8.17 ms
a50b33d+dirty 1197.74 ms 1197.17 ms -0.57 ms
3d377b5+dirty 1218.48 ms 1219.51 ms 1.03 ms
5569641+dirty 3839.22 ms 1231.30 ms -2607.91 ms
23598c3+dirty 1207.00 ms 1209.90 ms 2.90 ms

App size

Revision Plain With Sentry Diff
bc0d8cf+dirty 5.15 MiB 6.67 MiB 1.51 MiB
7d6fd3a+dirty 3.38 MiB 4.77 MiB 1.39 MiB
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB
5fe1c6c+dirty 3.38 MiB 4.77 MiB 1.39 MiB
4e0ba9c+dirty 5.15 MiB 6.67 MiB 1.51 MiB
2c735cc+dirty 3.38 MiB 4.74 MiB 1.35 MiB
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB
3d377b5+dirty 3.38 MiB 4.76 MiB 1.38 MiB
5569641+dirty 5.15 MiB 6.67 MiB 1.51 MiB
23598c3+dirty 3.38 MiB 4.80 MiB 1.42 MiB

Previous results on branch: alwx/fixes/duplicate-js-error-app-start-init

Startup times

Revision Plain With Sentry Diff
47e8ca3+dirty 3833.33 ms 1212.98 ms -2620.35 ms

App size

Revision Plain With Sentry Diff
47e8ca3+dirty 5.15 MiB 6.67 MiB 1.52 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 3838.54 ms 1223.36 ms -2615.19 ms
Size 5.15 MiB 6.68 MiB 1.53 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc0d8cf+dirty 3834.64 ms 1223.91 ms -2610.73 ms
7d6fd3a+dirty 1210.89 ms 1217.63 ms 6.74 ms
df5d108+dirty 1207.34 ms 1210.50 ms 3.16 ms
5fe1c6c+dirty 1201.36 ms 1209.15 ms 7.78 ms
4e0ba9c+dirty 3856.39 ms 1234.44 ms -2621.95 ms
2c735cc+dirty 1223.33 ms 1224.38 ms 1.04 ms
a50b33d+dirty 1207.11 ms 1212.10 ms 5.00 ms
3d377b5+dirty 1201.55 ms 1201.80 ms 0.25 ms
5569641+dirty 3824.35 ms 1210.78 ms -2613.57 ms
23598c3+dirty 1223.59 ms 1229.13 ms 5.53 ms

App size

Revision Plain With Sentry Diff
bc0d8cf+dirty 5.15 MiB 6.67 MiB 1.51 MiB
7d6fd3a+dirty 3.38 MiB 4.77 MiB 1.39 MiB
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB
5fe1c6c+dirty 3.38 MiB 4.77 MiB 1.39 MiB
4e0ba9c+dirty 5.15 MiB 6.67 MiB 1.51 MiB
2c735cc+dirty 3.38 MiB 4.74 MiB 1.35 MiB
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB
3d377b5+dirty 3.38 MiB 4.76 MiB 1.38 MiB
5569641+dirty 5.15 MiB 6.67 MiB 1.51 MiB
23598c3+dirty 3.38 MiB 4.80 MiB 1.42 MiB

Previous results on branch: alwx/fixes/duplicate-js-error-app-start-init

Startup times

Revision Plain With Sentry Diff
47e8ca3+dirty 3834.71 ms 1221.74 ms -2612.97 ms

App size

Revision Plain With Sentry Diff
47e8ca3+dirty 5.15 MiB 6.67 MiB 1.52 MiB

@sentry
Copy link
Copy Markdown

sentry Bot commented May 13, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.11.1 (88) Release

⚙️ sentry-react-native Build Distribution Settings

The original entry landed in the already-released 8.11.0 section and
linked to /pulls/6145 instead of /pull/6145. Danger flagged the former.
Move the entry under ## Unreleased → ### Fixes and correct the URL.
@alwx alwx merged commit 9210ae6 into main May 13, 2026
84 checks passed
@alwx alwx deleted the alwx/fixes/duplicate-js-error-app-start-init branch May 13, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 8.x.x with Capture App Start Errors enabled - duplicate JS issue reporting

2 participants