Skip to content

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented May 19, 2017

This heavily improves react-native link and unlink.

The idea is that we do some stuff on link that generally makes sense and then persist through unlink and relink. This way users can "upgrade" by unlinking and re-linking to newer react-native sentry versions.

link

@mitsuhiko mitsuhiko requested a review from HazAT May 19, 2017 22:37
@mitsuhiko
Copy link
Contributor Author

TODO:

  • if we launch this after our swift -> objc rewrite is through we should remove the swift flag flipping
  • consider undoing old SENTRY_ORG exports and others in the react native build script we let users patch in the past. If we don't do that we should add some upgrade docs so that users can do that manually.

@mitsuhiko
Copy link
Contributor Author

All todo steps are done now and the docs are also updated. We should be careful when pulling this in as the docs will rebuild automatically. So this should only be merged when we do the actual release.

@HazAT HazAT merged commit 132522c into master May 23, 2017
@HazAT HazAT deleted the feature/improved-linking branch May 23, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants