union instead of concatenation, because duplicate fields #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh hi Jared! Do I get to bother you to add a test case? |
Contributor
Author
|
yes |
Contributor
|
I like #295. I think it would be best if sanitize_fields was just a simple array. By default, the array is filled with the default list, but you can manipulate it as you would an array to modify. |
Contributor
Author
|
@nateberkopec added test case |
Contributor
There was a problem hiding this comment.
Shouldn't we use a field like "password" or something? Neither of the fields you're adding here are in DEFAULT_FIELDS
Contributor
Author
There was a problem hiding this comment.
Right, but I'm adding those to the list of default fields and assigning all of that to sanitize_fields.
nateberkopec
added a commit
that referenced
this pull request
Feb 4, 2015
union instead of concatenation, because duplicate fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.