Skip to content

union instead of concatenation, because duplicate fields #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2015
Merged

union instead of concatenation, because duplicate fields #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/raven/processor/sanitizedata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def sanitize_query_string(query_string)
end

def fields_re
@fields_re ||= /(#{(DEFAULT_FIELDS + @sanitize_fields).join("|")})/i
@fields_re ||= /(#{(DEFAULT_FIELDS | @sanitize_fields).join("|")})/i
end
end
end
Expand Down
12 changes: 12 additions & 0 deletions spec/raven/configuration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,16 @@
end
end

context 'configuration for sanitize fields' do
it 'should union default sanitize fields with user-defined sanitize fields' do
fields = Raven::Processor::SanitizeData::DEFAULT_FIELDS | %w(test monkeybutt)
Copy link
Contributor

@nateberkopec nateberkopec Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use a field like "password" or something? Neither of the fields you're adding here are in DEFAULT_FIELDS

Copy link
Contributor Author

@wyattisimo wyattisimo Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but I'm adding those to the list of default fields and assigning all of that to sanitize_fields.

Copy link
Contributor

@nateberkopec nateberkopec Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right you are!


subject.sanitize_fields = fields
client = Raven::Client.new(subject)
processor = Raven::Processor::SanitizeData.new(client)

expect(processor.send(:fields_re)).to eq(/(#{fields.join('|')})/i)
end
end

end