Send environment from current_environment #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future change might involve renaming current_environment to environment and environments to something that looks like like the core attribute. @getsentry/ruby
| data[:culprit] = @culprit if @culprit | ||
| data[:server_name] = @server_name if @server_name | ||
| data[:release] = @release if @release | ||
| data[:environment] = @envirionment if @environment |
There was a problem hiding this comment.
Looks like @envirionment is misspelled.
Member
Author
There was a problem hiding this comment.
this was fixed in a followup commit
There was a problem hiding this comment.
Ok, thanks! (and sorry for not looking more closely)
Contributor
There was a problem hiding this comment.
Don't sweat it, I merged it and missed the same thing! 😆
alexford
pushed a commit
to alexford/raven-ruby
that referenced
this pull request
Jan 1, 2017
Usage:
Without the header option, both request / response headers are logged (backwards compatibility).
```ruby
Faraday.new do |c|
c.response :logger, Logger.new(STDOUT)
end
Faraday.new do |c|
c.response :logger, Logger.new(STDOUT), headers: false
end
Faraday.new do |c|
c.response :logger, Logger.new(STDOUT), headers: { request: false }
end
Faraday.new do |c|
c.response :logger, Logger.new(STDOUT), headers: { response: false }
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future change might involve renaming current_environment to environment and environments to something that looks like like the core attribute.
@getsentry/ruby
This change is