Skip to content

Send environment from current_environment #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2016
Merged

Send environment from current_environment #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/raven/event.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Event
attr_reader :id
attr_accessor :project, :message, :timestamp, :time_spent, :level, :logger,
:culprit, :server_name, :release, :modules, :extra, :tags, :context, :configuration,
:checksum, :fingerprint
:checksum, :fingerprint, :environment

def initialize(init = {})
@configuration = Raven.configuration
Expand All @@ -49,6 +49,7 @@ def initialize(init = {})
@tags = {}
@checksum = nil
@fingerprint = nil
@environment = @configuration.current_environment

yield self if block_given?

Expand Down Expand Up @@ -220,6 +221,7 @@ def to_hash
data[:culprit] = @culprit if @culprit
data[:server_name] = @server_name if @server_name
data[:release] = @release if @release
data[:environment] = @envirionment if @environment
Copy link

@aortez aortez Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @envirionment is misspelled.

Copy link
Member Author

@dcramer dcramer Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was fixed in a followup commit

Copy link

@aortez aortez Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! (and sorry for not looking more closely)

Copy link
Contributor

@nateberkopec nateberkopec Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't sweat it, I merged it and missed the same thing! 😆

data[:fingerprint] = @fingerprint if @fingerprint
data[:modules] = @modules if @modules
data[:extra] = @extra if @extra
Expand Down