MessageInterface support for invalid format string msg when params is… #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Whoops that's pretty bad. Will get this fixed and a 2.2.1 out ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having a problem were certain errors were not being reported.
The cause was that
MessageInterface#unformatted_messagewas producing an ArgumentError: malformed format string. This was due to the message being an invalid format string (e.g.: Process failed at char '%'). This occurred even tough there were noparamsdefined.I changed the behaviour of
MessageInterface#unformatted_messageto not apply theparamsto themessageusing%if there were noparamsdefined.Not sure if there a more appropriate way to solve this issue. In any case the test case might be helpful.