Skip to content

MessageInterface support for invalid format string msg when params is… #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2016
Merged

MessageInterface support for invalid format string msg when params is… #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d25ff
MessageInterface support for invalid format string msg when params is…
jmalves Oct 20, 2016
719e7b2
Fixed missing params indefinition in MessageInterface spec
jmalves Oct 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/raven/interfaces/message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def initialize(*arguments)
end

def unformatted_message
message % params
params.nil? ? message : message % params
end

def self.sentry_alias
Expand Down
7 changes: 7 additions & 0 deletions spec/raven/interface_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,10 @@ class TestInterface < Raven::Interface
expect(interface.to_hash).to eq(:some_attr => "test")
end
end

describe Raven::MessageInterface do
it "supports invalid format string message when params is not defined" do
interface = Raven::MessageInterface.new(:params => nil, :message => "test '%'")
expect(interface.unformatted_message).to eq("test '%'")
end
end