Skip to content

fix!(sentry-core): Make Scope UnwindSafe#1093

Merged
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/scope-semver
Apr 28, 2026
Merged

fix!(sentry-core): Make Scope UnwindSafe#1093
szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex/scope-semver

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

Make Scope UnwindSafe even when client feature is enabled.

BREAKING CHANGE: sentry_core::Scope::add_event_processor now requires the passed closures to be RefUnwindSafe.

Closes #1088
Closes RUST-201

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 27, 2026

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/scope-semver branch 3 times, most recently from c23b35c to bc6c392 Compare April 27, 2026 14:47
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 27, 2026 14:48
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner April 27, 2026 14:48
Make `Scope` `UnwindSafe` even when `client` feature is enabled.

BREAKING CHANGE: `sentry_core::Scope::add_event_processor` now requires the passed closures to be `RefUnwindSafe`.

Closes #1088
Closes [RUST-201](https://linear.app/getsentry/issue/RUST-201/sentry-core-make-noop-scope-non-unwindsafe-to-match-the-client)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/scope-semver branch from bc6c392 to 489cbb8 Compare April 27, 2026 16:27
@szokeasaurusrex szokeasaurusrex merged commit 1fd2d91 into master Apr 28, 2026
24 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/scope-semver branch April 28, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentry-core: make noop Scope non-UnwindSafe to match the client implementation

2 participants