ref(hub): Remove boolean to track if we are using process hub#1125
Open
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/process-hub-structfrom
Open
ref(hub): Remove boolean to track if we are using process hub#1125szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/process-hub-structfrom
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/process-hub-structfrom
Conversation
Instead, it is simpler just to set the `THREAD_HUB` to the `PROCESS_HUB` (or, more specifically, an Arc-clone of it).
szokeasaurusrex
commented
May 8, 2026
| { | ||
| THREAD_HUB.with(|(hub, is_process_hub)| { | ||
| if is_process_hub.get() { | ||
| f(&PROCESS_HUB.hub) |
Member
Author
There was a problem hiding this comment.
As I understand it, this was the sole purpose of is_process_hub: so that when we are on the thread that created the hub, the current hub is the PROCESS_HUB.
The changes here eliminate the need to track is_process_hub separately, since we just make the thread hub an arc-clone of the process hub on the thread that creates the process hub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, it is simpler just to set the
THREAD_HUBto thePROCESS_HUB(or, more specifically, an Arc-clone of it).Stacked on #1124