feat: Add per-request sessions to actix integration #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
feat/actix-sessions
branch
from
69037c5 to
7439180
Compare
Swatinem
force-pushed
the
feat/actix-sessions
branch
from
7439180 to
5c19d89
Compare
flub
reviewed
Sep 17, 2020
| } | ||
|
|
||
| /// Reports certain failures to sentry. | ||
| //#[derive(Clone)] |
Contributor
There was a problem hiding this comment.
Not related to this PR really, but we don't make this Debug?
| let root_scope = hub.push_scope(); | ||
| if self.track_session { | ||
| hub.start_session(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It stops when the scope goes out of scope :-D
Contributor
Author
|
old actix is gone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #240 , this has to be opt-in for now, as the actix middleware currently has no way to disable the user-mode session which is now the default on the main Hub.