Skip to content

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Aug 14, 2020

This adds release health sessions to the SDK, with some things that require special attention:

  • sessions live on the scope.
  • sessions are forward-inherited, which means that creating a new Hub from another one, and pushing scopes will use the exact same session.
  • however, sessions are not backward-inherited, which means that starting a new session will not propagate backwards to any parent scopes/hubs.

So far, intermediate session updates are sent along with normal events, however session end updates are sent on their own and not yet batched together. This means that request-mode sessions are not yet as efficient as we would like them to be.

@Swatinem Swatinem requested a review from a team August 31, 2020 09:53
@Swatinem Swatinem marked this pull request as ready for review August 31, 2020 09:54
@Swatinem Swatinem merged commit ca84eaa into master Sep 4, 2020
@Swatinem Swatinem deleted the feat/sessions branch September 4, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants