Skip to content

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Sep 7, 2020

No description provided.

@Swatinem Swatinem requested a review from a team September 7, 2020 11:13
targets:
- name: crates
noDevDeps: true
- name: gh-pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that because the artifact is missing or are we removing GH pages entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That stuff was previously built in a travis job. Its basically duplicated with docs.rs: https://getsentry.github.io/sentry-rust/sentry/

So I think we should remove it in favor of that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I believe we introduced this slightly before docs.rs was a thing but kept it alive. I'm fine with turning off completely 👍

@Swatinem Swatinem merged commit 2a987aa into master Sep 7, 2020
@Swatinem Swatinem deleted the ci/rm-appveyor branch September 7, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants