fix: Make the Logger completely self-contained #261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `with_integration`, which can potentially lock on every call, we rather unsafely move the `dest_log` into our own Logger.
Swatinem
force-pushed
the
fix/lockless-logger
branch
from
1e67d87 to
2954c6f
Compare
jan-auer
reviewed
Sep 14, 2020
Comment on lines
+56
to
+58
| let const_ptr = &self.dest_log as *const Option<Box<dyn log::Log>>; | ||
| let mut_ptr = const_ptr as *mut Option<Box<dyn log::Log>>; | ||
| (&mut *mut_ptr).take() |
Member
There was a problem hiding this comment.
Okay, I know that I may have suggested this in a meeting, but we need to find another way to do this. If we end up breaking all integration interfaces to make them builders, I guess that is fine and a good lesson on why we should not expose fields publicly :)
To quote https://doc.rust-lang.org/nightly/nomicon/transmutes.html (UB = undefined behavior):
- Transmuting an & to &mut is always UB.
- No you can't do it.
- No you're not special.
Contributor
Author
|
closing this in favor of #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
with_integration, which can potentially lock on every call, we rather unsafely move thedest_loginto our own Logger.