Skip to content

fix: Set a default environment based on debug_assertions #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020
Merged

fix: Set a default environment based on debug_assertions #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d43aa
fix: Set a default environment based on debug_assertions
Swatinem Oct 15, 2020
e29e7b4
Merge branch 'master' into fix/defaulted-env
Swatinem Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sentry-core/src/clientoptions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ pub struct ClientOptions {
/// The release to be sent with events.
pub release: Option<Cow<'static, str>>,
/// The environment to be sent with events.
///
/// Defaults to either `"development"` or `"production"` depending on the
/// `debug_assertions` cfg-attribute.
pub environment: Option<Cow<'static, str>>,
/// The sample rate for event submission. (0.0 - 1.0, defaults to 1.0)
pub sample_rate: f32,
Expand Down Expand Up @@ -163,11 +166,16 @@ impl fmt::Debug for ClientOptions {

impl Default for ClientOptions {
fn default() -> ClientOptions {
let env = if cfg!(debug_assertions) {
"development"
} else {
"production"
};
ClientOptions {
dsn: None,
debug: false,
release: None,
environment: None,
environment: Some(env.into()),
sample_rate: 1.0,
max_breadcrumbs: 100,
attach_stacktrace: false,
Expand Down