Add SpanStatus to the protocol. #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Jul 12, 2021
|
|
||
| /// The status of a Span. | ||
| #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq, Hash)] | ||
| pub enum SpanStatus { |
There was a problem hiding this comment.
please make this #[non_exhaustive]
sentry-types/src/protocol/v7.rs
Outdated
| } | ||
|
|
||
| impl str::FromStr for SpanStatus { | ||
| type Err = ParseLevelError; |
There was a problem hiding this comment.
Maybe a more descriptive error would be a good idea. I have to look at more examples, I’m not sure what kind of errors we use for all the other enums here.
There was a problem hiding this comment.
I am sorry, going to add ParseStatusError struct and use it here.
Swatinem
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
SpanStatusenumeration to the protocol according to the documentation Span InterfaceIt also changes
statusfield type fromOption<String>toOption<SpanStatus>forSpanandTransaction.