Skip to content

Update changelog #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2021
Merged

Update changelog #384

merged 1 commit into from
Nov 10, 2021

Conversation

@loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Nov 10, 2021

I don't think we need a changelog entry for this.

@loewenheim loewenheim requested a review from Swatinem November 10, 2021 11:06
@Swatinem Swatinem merged commit 4303c48 into master Nov 10, 2021
@Swatinem Swatinem deleted the meta/update-changelog branch November 10, 2021 11:19
@Swatinem
Copy link
Member

Swatinem commented Nov 10, 2021

meh, maybe I was a bit overeager to merge this.
other breaking changes would have been:

  • updating the tracing-subscriber dependency
  • changing the signature of Scope::add_event_processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Swatinem Swatinem Swatinem approved these changes

+1 more reviewer

@flub flub flub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loewenheim @Swatinem @flub