Fix raw envelope roundtrips #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to print an empty `{}` header in front of raw envelopes, which is wrong.
Now we test for perfect roundtrips of arbitrary bytes, which is what "raw" means.
Also offers a `from_bytes_raw` now which takes an in-memory buffer.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 70.50% 70.64% +0.13%
==========================================
Files 66 66
Lines 6680 6698 +18
==========================================
+ Hits 4710 4732 +22
+ Misses 1970 1966 -4 |
loewenheim
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to print an empty
{}header in front of raw envelopes, which is wrong.Now we test for perfect roundtrips of arbitrary bytes, which is what "raw" means. Also offers a
from_bytes_rawnow which takes an in-memory buffer.