Enable building sentry-tower and sentry-tracing with all features on docs.rs #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Sep 13, 2023
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Contributor
|
Would you mind merging or rebasing on top of master? We had some cleanup to do. |
FSMaxB
force-pushed
the
docs-rs-all-features
branch
from
ffb3082 to
4ac7954
Compare
Contributor
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found e.g.
SentryHttpLayermissing from docs.rs forsentry-towerso I went ahead and added the necessarydocs.rsmetadata toCargo.tomlforsentry-towerandsentry-tracing(those were the packages with non-default features that didn't have it enabled yet).