Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Sep 19, 2025

Description

I am not sure the changes in #887 are fully beneficial, as it might have been useful to users to see the module where each span comes from at a glance in the UI.
For that reason, this PR changes the default op to be "<span target>::<span name>" which becomes "<module>::<function>" for spans created via tracing::instrument.

Combining the changes in this and the previous PR, the effect is that, for tracing::instrument spans, the name and op will be simply swapped with respect to the previous release.

Result in the UI:
Screenshot 2025-09-22 at 15 00 46

Previous version for comparison:
Screenshot 2025-09-22 at 15 05 47

#skip-changelog as I'm updating the previous changelog entry

@lcian lcian changed the base branch from master to lcian/skip-default-attributes September 19, 2025 15:05
@lcian lcian marked this pull request as ready for review September 22, 2025 13:07
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.45%. Comparing base (75aff83) to head (2198c50).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   73.46%   73.45%   -0.01%     
==========================================
  Files          64       64              
  Lines        7517     7518       +1     
==========================================
  Hits         5522     5522              
- Misses       1995     1996       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from lcian/skip-default-attributes to master September 23, 2025 07:50
@lcian lcian enabled auto-merge (squash) September 23, 2025 07:51
@lcian lcian merged commit 1c08ca8 into master Sep 23, 2025
19 checks passed
@lcian lcian deleted the lcian/keep-old-op branch September 23, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants