'accesslog' settings in SENTRY_WEB_OPTIONS is disabled by the default LOGGING config in conf/server.py

[mrkschan]

I was trying to enable access log on gunicorn and adding 'accesslog' option to SENTRY_WEB_OPTIONS.

SENTRY_WEB_OPTIONS = {
    'workers': 16,  # the number of gunicorn workers
    'limit_request_line': 0,  # required for raven-js
    'secure_scheme_headers': {'X-FORWARDED-PROTO': 'https'},
    'accesslog': '-',   # access log to stderr
}

This settings alone cannot achieve my purpose since the logging dictconfig in sentry/conf/server.py used 'disable_existing_loggers' = True.

Thus, I have to add LOGGING['disable_existing_loggers'] = False to my sentry.conf.py in order to "re-enable" the loggers in gunicorn.

Is this the expected behavior or the gunicorn log config is ignored by accident?

[dcramer]

Honestly, I'm not really sure. In the future we plan to move off of gunicorn, and we've already stopped using it on getsentry.com. I'm happy to accept a PR to address this issue, though I'm not sure if changing disable_existing_loggers (by default) is a good idea.

[mrkschan]

Is adding a doc section to mention this gunicorn access log settings appropriate?

[dcramer]

@mrkschan yeah that seems reasonable