subscribe_notes ignored in unicode-sensitive comparison

[janfabry]

I have disabled subscribe_notes, but I still get notifications of new notes. I think this is due to a Unicode-aware comparison.

>>> UserOption.objects.filter(key='subscribe_notes', value='0')
[]
>>> UserOption.objects.filter(key='subscribe_notes', value=u'0')
[<UserOption at 0x4505110: id=73, user_id=1, project_id=None, key=u'subscribe_notes', value=u'0'>, <UserOption at 0x4505190: id=137, user_id=2, project_id=None, key=u'subscribe_notes', value=u'0'>]

Activity.send_notification compares with '0', and thus never returns me as a user to exclude.

Python 2.7.3, Postgres 9.2.5

[mattrobenolt]

Hmm, that's weird. I'll take a look at this later.

[mattrobenolt]

Also, what db are you using? Is this on postgres?

[mattrobenolt]

Oh, nevermind! You mention it. :)

[dcramer]

This was by far the most obscure bug. We had a lot of reports of this and couldnt never pinpoint it, but sure enough, this was the issue. It's purely because of pickle and how it treats the values differently.

[dcramer]

Fixed in a17fb9b