Replay loading hangs due to `ContextPropagatingThreadPoolExecutor`

[DanielMcAssey]

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

1. Open a replay that has multiple recording segments
2. Attemot to load or play the Replay in the UI

Expected Result

The Replay loads normally and begins playback.

Actual Result

The Replay hangs while loading and does not begin playback. Applying a patch to revert ContextPropagatingThreadPoolExecutor back to ThreadPoolExecutor in src/sentry/replays/usecases/reader.py resolves the issue.

Introduced by this PR: #111460
I also think the ContextPropagatingThreadPoolExecutor is responsible for the issues seen here: getsentry/self-hosted#4326

Product Area

Replays

Link

No response

DSN

No response

Version

26.4.2

[linear-code]

ENG-7719

[getsantry]

Assigning to @getsentry/support for routing ⏲️

[DanielMcAssey]

Patch for the self-hosted folk.

--- src/sentry/replays/usecases/reader.py
+++ src/sentry/replays/usecases/reader.py
@@ -3,6 +3,7 @@
 import uuid
 import zlib
 from collections.abc import Generator, Iterator
+from concurrent.futures import ThreadPoolExecutor
 from datetime import datetime, timedelta
 from typing import Any
 
@@ -28,6 +29,5 @@
 from sentry.replays.lib.storage import RecordingSegmentStorageMeta, filestore, storage
 from sentry.replays.models import ReplayRecordingSegment
 from sentry.replays.usecases.pack import unpack
-from sentry.utils.concurrent import ContextPropagatingThreadPoolExecutor
 from sentry.utils.snuba import raw_snql_query
 
@@ -263,7 +263,7 @@
 def iter_segment_data(
     segments: list[RecordingSegmentStorageMeta],
 ) -> Generator[tuple[int, memoryview]]:
-    with ContextPropagatingThreadPoolExecutor(max_workers=10) as pool:
+    with ThreadPoolExecutor(max_workers=10) as pool:
         segment_data = pool.map(_download_segment, segments)
 
     for i, result in enumerate(segment_data):

[cuchac]

I confirm @DanielMcAssey patch fixes this issue.
We waited 3 weeks for #113643 fix to propagate to release. Is it possible to release this fix faster to shorten replays unavailability window?
Thanks!

[getsantry]

Routing to @getsentry/product-owners-replays for triage ⏲️