feat(tasks) Add parameters to instrumented_task()#100536
Merged
Merged
Conversation
I'd like to deprecated and remove `TaskworkerConfig`. Before that can be done, we need to have parameters on `instrumented_task`. Refs STREAM-435
markstory
commented
Sep 29, 2025
| def instrumented_task( | ||
| name, | ||
| name: str, | ||
| namespace: TaskNamespace | None = None, |
Member
Author
There was a problem hiding this comment.
This None will be removed once all tasks have been updated.
evanh
approved these changes
Oct 1, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 1, 2025
I'd like to deprecated and remove `TaskworkerConfig`. Before that can be done, we need to have parameters on `instrumented_task`. Refs STREAM-435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to deprecated and remove
TaskworkerConfig. Before that can be done, we need to have parameters oninstrumented_task.Refs STREAM-435
Note
Extend instrumented_task to accept task parameters directly and refactor Sentry App tasks to specify silo_mode without TASK_OPTIONS; add tests covering new parameters.
namespace,retry,expires,processing_deadline_duration,at_most_once,wait_for_delivery,compression_type) and allow using eithernamespaceortaskworker_config.CompressionType,TaskNamespace, andRetry.src/sentry/sentry_apps/tasks/sentry_apps.py):TASK_OPTIONS/CONTROL_TASK_OPTIONSusage; passsilo_mode=SiloMode.REGION|CONTROLdirectly on@instrumented_taskacross task definitions.instrumented_taskparameters are applied (verifiescompression_typeandretrysettings).Retryand registry APIs.Written by Cursor Bugbot for commit 0d8a7bb. This will update automatically on new commits. Configure here.