Skip to content

Conversation

@priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Oct 1, 2025

Example Before

Screen.Recording.2025-10-01.at.11.53.05.mov

Example After

Screen.Recording.2025-10-01.at.11.52.08.mov

closes https://linear.app/getsentry/issue/TET-1176/onboarding-minidump-setting-makes-page-jump

@linear
Copy link

linear bot commented Oct 1, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 1, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review October 1, 2025 09:54
@priscilawebdev priscilawebdev requested a review from a team as a code owner October 1, 2025 09:54
@priscilawebdev priscilawebdev requested a review from a team October 1, 2025 09:54
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just globally set this to auto?

@priscilawebdev priscilawebdev requested review from a team as code owners October 1, 2025 18:56
@priscilawebdev priscilawebdev removed request for a team October 1, 2025 19:06
@priscilawebdev priscilawebdev removed the Scope: Backend Automatically applied to PRs that change backend components label Oct 1, 2025
@priscilawebdev
Copy link
Member Author

Should we just globally set this to auto?

sure! it is done in the commit 😉

<ResultsLimitSelector
disabled={disableSortDirection && disableSort}
name="resultsLimit"
menuPlacement="auto"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked everywhere where menuplacement="auto" was removed and everything works as expected

@priscilawebdev priscilawebdev changed the title fix(onboarding): Page jumping when opening further settings dropdown feat(ui): Set Select's menuReplacement prop default to 'auto' Oct 2, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review October 2, 2025 05:04
@TkDodo
Copy link
Collaborator

TkDodo commented Oct 2, 2025

Should we just globally set this to auto?

I agree. Since there is no other usage that sets menuPlacement to anything but auto, we should remove the prop and hard-code it to auto. That simplifies the API surface.

@priscilawebdev
Copy link
Member Author

Should we just globally set this to auto?

I agree. Since there is no other usage that sets menuPlacement to anything but auto, we should remove the prop and hard-code it to auto. That simplifies the API surface.

That has already done, but I haven’t removed the ability to customize it. Users can still set a Select component to 'bottom' if they wish. Would you like me to remove this option entirely?

@priscilawebdev priscilawebdev requested a review from TkDodo October 2, 2025 07:51
@TkDodo
Copy link
Collaborator

TkDodo commented Oct 2, 2025

Would you like me to remove this option entirely?

yeah I think we don’t need to allow customizing an option that we don’t intend to use.

@priscilawebdev priscilawebdev merged commit a84eb58 into master Oct 3, 2025
47 checks passed
@priscilawebdev priscilawebdev deleted the priscila/fix/onboarding/add-menuPlacement-auto-to-further-settings-selector branch October 3, 2025 05:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants