-
-
Couldn't load subscription status.
- Fork 4.5k
feat(ui): Set Select's menuReplacement prop default to 'auto' #100658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Set Select's menuReplacement prop default to 'auto' #100658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just globally set this to auto?
…auto-to-further-settings-selector
sure! it is done in the commit 😉 |
| <ResultsLimitSelector | ||
| disabled={disableSortDirection && disableSort} | ||
| name="resultsLimit" | ||
| menuPlacement="auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked everywhere where menuplacement="auto" was removed and everything works as expected
…auto-to-further-settings-selector
I agree. Since there is no other usage that sets |
That has already done, but I haven’t removed the ability to customize it. Users can still set a Select component to 'bottom' if they wish. Would you like me to remove this option entirely? |
yeah I think we don’t need to allow customizing an option that we don’t intend to use. |
Example Before
Screen.Recording.2025-10-01.at.11.53.05.mov
Example After
Screen.Recording.2025-10-01.at.11.52.08.mov
closes https://linear.app/getsentry/issue/TET-1176/onboarding-minidump-setting-makes-page-jump