ref(onboarding): Move onboarding context into onboarding #100770
Conversation
github-actions
bot
added
the
Scope: Frontend
| `; | ||
|
|
||
| export default Onboarding; | ||
| export default OnboardingWithProvider; |
There was a problem hiding this comment.
This is more of a learning question than anything else, but why don't we have to update the imports for this anywhere? Is this some automatic import regardless of object name or something?
There was a problem hiding this comment.
default imports / exports ignore naming
I could import this as import Foo from 'sentry/views/onboarding/onboarding'
There was a problem hiding this comment.
I believe the onboarding context was originally made global because data was shared between onboarding (new users) and project creation. I double-checked, and it’s now only used in the onboarding pages/hooks. We can safely remove it from this file
as well.
Good update! thank you 🙌
…ng/move-onboarding-context-into-onboarding
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100770 +/- ##
===========================================
- Coverage 81.10% 81.10% -0.01%
===========================================
Files 8666 8666
Lines 384544 384543 -1
Branches 24269 24269
===========================================
- Hits 311867 311866 -1
Misses 72332 72332
Partials 345 345 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| })} | ||
| /> | ||
| )} | ||
| </GettingStartedLayout> |
There was a problem hiding this comment.
Bug: Context Removal Causes Child Component Failures
Removing the OnboardingContextProvider from GettingStarted may cause runtime errors. If ProjectInstallPlatform or its children use useOnboardingContext(), the missing context will lead to crashes.
ArthurKnaus
deleted the
aknaus/ref/onboarding/move-onboarding-context-into-onboarding
branch
Move the onboarding context provider into the onboarding route instead of wrapping it around the whole app.
Reduces risk of breaking things and reduces wrong issue assignments via codeowners.