ref(cleanup): More functions #101066
ref(cleanup): More functions #101066
Conversation
This helps with the readability of the code.
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
| return False | ||
| return model.__name__.lower() not in model_list | ||
|
|
||
| bulk_query_deletes = generate_bulk_query_deletes() |
There was a problem hiding this comment.
This call is only needed within run_bulk_query_deletes.
| models_attempted, | ||
| ) | ||
|
|
||
| debug_output("Running bulk deletes in DELETES") |
There was a problem hiding this comment.
This code has been moved within this function:
https://github.com/getsentry/sentry/pull/101066/files#diff-af1cde82f065157a87af5b9c019c93a9e93aeb22661494449dbca1628e3cf306R559
| models_attempted, | ||
| ) | ||
|
|
||
| if project_deletion_query is not None and len(to_delete_by_project): |
There was a problem hiding this comment.
This code has been moved within:
https://github.com/getsentry/sentry/pull/101066/files#diff-af1cde82f065157a87af5b9c019c93a9e93aeb22661494449dbca1628e3cf306R592
| task_queue, project, project_id, is_filtered, days, models_attempted | ||
| ) | ||
|
|
||
| if organization_deletion_query is not None and len(to_delete_by_organization): |
There was a problem hiding this comment.
This code has been moved within this function:
https://github.com/getsentry/sentry/pull/101066/files#diff-af1cde82f065157a87af5b9c019c93a9e93aeb22661494449dbca1628e3cf306R632
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| def _stop_pool(pool: Sequence[Process], task_queue: _WorkQueue) -> None: | ||
| # First, ensure all queued tasks are completed | ||
| task_queue.join() |
There was a problem hiding this comment.
Whenever an exception is raised inside of the try/block, it may leave us without calling task_queue.join() in one of the steps, thus, it may make sense to completing the tasks before shutting down the pool.
This helps with the readability of the code.