ref(transactions): Remove usage of deprecatedRouteProps from TransactionOverview view#101093
Closed
shashjar wants to merge 1 commit into
Closed
ref(transactions): Remove usage of deprecatedRouteProps from TransactionOverview view#101093shashjar wants to merge 1 commit into
deprecatedRouteProps from TransactionOverview view#101093shashjar wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
gggritso
reviewed
Oct 14, 2025
gggritso
left a comment
gggritso
left a comment
Member
There was a problem hiding this comment.
Cool, thank you! One question about mocking navigations, otherwise LGTM
Comment on lines
+25
to
+29
| const mockNavigate = jest.fn(); | ||
| jest.mock('sentry/utils/useNavigate', () => ({ | ||
| useNavigate: () => mockNavigate, | ||
| })); | ||
|
|
Member
There was a problem hiding this comment.
👀 I think you can replace this mock with assertion for router.location.url instead, per the docs!
Collaborator
There was a problem hiding this comment.
bad timing on my part but I have a PR up that adds a shared layout to all /summary pages for faster navigation, and I also had to change all the tests because of it, therefore removing the deprecatedRouterProps implicitly 😅 🙈
Here’s how I removed the mocking (PR is still in draft):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates usage of
deprecatedRoutePropsforTransactionOverview-sentry/views/performance/transactionSummary/transactionOverview.https://www.notion.so/sentry/Frontend-TSC-Project-Remove-all-uses-of-deprecatedRouteProps-true-26a8b10e4b5d8015a6a2dd14f9d41dd7