feat(eap): Sets up double deletion of occurrences with EAP #101385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Oct 10, 2025
shashjar
commented
Oct 10, 2025
shashjar
commented
Oct 10, 2025
shashjar
commented
Oct 10, 2025
| from sentry.testutils.cases import TestCase | ||
|
|
||
|
|
||
| class TestEAPDeletion(TestCase): |
Member
Author
There was a problem hiding this comment.
Basic tests for now, to be improved later
shashjar
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101385 +/- ##
========================================
Coverage 80.96% 80.96%
========================================
Files 8709 8710 +1
Lines 387385 387420 +35
Branches 24523 24523
========================================
+ Hits 313651 313684 +33
- Misses 73386 73388 +2
Partials 348 348 |
thetruecpaul
approved these changes
Oct 29, 2025
Contributor
thetruecpaul
left a comment
thetruecpaul
left a comment
There was a problem hiding this comment.
Discussed with EAP team re: using attr instead of trace ID, they said we should set up our systems how we want and let them build the systems under us
roggenkemper
added a commit
that referenced
this pull request
Nov 4, 2025
option got overwritten in #101385 , re-adds it back fixes SENTRY-5BYE
shashjar
added a commit
that referenced
this pull request
Nov 4, 2025
Sets up double deletion of occurrences with EAP, as described in [ID-997](https://linear.app/getsentry/issue/ID-997/set-up-double-deletions-with-eap). When deleting events from eventstore, we should also delete from EAP using the in-progress `DeleteTraceItems` endpoint ([protobuf definition](https://github.com/getsentry/sentry-protos/blob/main/proto/sentry_protos/snuba/v1/endpoint_delete_trace_items.proto)). Rolling out behind an organization allowlist feature flag (empty for foreseeable future), so this won't be running once merged.
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
Sets up double deletion of occurrences with EAP, as described in [ID-997](https://linear.app/getsentry/issue/ID-997/set-up-double-deletions-with-eap). When deleting events from eventstore, we should also delete from EAP using the in-progress `DeleteTraceItems` endpoint ([protobuf definition](https://github.com/getsentry/sentry-protos/blob/main/proto/sentry_protos/snuba/v1/endpoint_delete_trace_items.proto)). Rolling out behind an organization allowlist feature flag (empty for foreseeable future), so this won't be running once merged.
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
option got overwritten in #101385 , re-adds it back fixes SENTRY-5BYE
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
option got overwritten in #101385 , re-adds it back fixes SENTRY-5BYE
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sets up double deletion of occurrences with EAP, as described in [ID-997](https://linear.app/getsentry/issue/ID-997/set-up-double-deletions-with-eap). When deleting events from eventstore, we should also delete from EAP using the in-progress `DeleteTraceItems` endpoint ([protobuf definition](https://github.com/getsentry/sentry-protos/blob/main/proto/sentry_protos/snuba/v1/endpoint_delete_trace_items.proto)). Rolling out behind an organization allowlist feature flag (empty for foreseeable future), so this won't be running once merged.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
option got overwritten in #101385 , re-adds it back fixes SENTRY-5BYE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up double deletion of occurrences with EAP, as described in ID-997.
When deleting events from eventstore, we should also delete from EAP using the in-progress
DeleteTraceItemsendpoint (protobuf definition).Rolling out behind an organization allowlist feature flag (empty for foreseeable future), so this won't be running once merged.