feat(eap): Enable deletion from EAP by default, with a killswitch option #102808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Nov 5, 2025
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
shashjar
deleted the
deletion-from-eap-enabled-set-option-default-true
branch
shashjar
added a commit
that referenced
this pull request
Nov 20, 2025
…m EAP (#103749) Follow-up to #102808. Fixes [SENTRY-5DA7](https://sentry.sentry.io/issues/7045968679?project=1). This PR ensures we provide the correct endpoint name when issuing RPC requests to `EndpointDeleteTraceItems`. We're currently passing "DeleteTraceItemsRequest" (the name of the protobuf definition) rather than "EndpointDeleteTraceItems" (the name of the RPC request handler Snuba-side). We should be able to verify this works based on the related [metrics](https://app.datadoghq.com/metric/explorer?fromUser=false&graph_layout=stacked&start=1763578929582&end=1763665329582&paused=false#N4Ig7glgJg5gpgFxALlAGwIYE8D2BXJVEADxQEYAaELcqyKBAC1pEbghkcLIF8qo4AMwgA7CAgg4RKUAiwAHOChASAtnADOcAE4RNIKtrgBHPJoQaUAbVBGN8qVoD6gnNtUZCKiOq279VKY6epbINiAiGOrKQdpYZAYgUJ4YThr42gDGSsgg6gi6mZaBZnHKGABuMMhaIgVYAHQCaIiSIhoNMNr48g1wGL2CGBBoeEbAAFQ8DRgaTpn4dQAUAJQgPAC6VK7ueJih4TuqexgxpfHrWyAaci0yIPIYLQgIOUk4MPP7GhCZiWiiOBOOSKZTpAFQf6Apz0JjKERuDxodb8CD2TBYYEKN4AkRKTY8PjXeQAhAAYSkwhgKBEezQPCAA) & Sentry issue (linked above).
shashjar
added a commit
that referenced
this pull request
Nov 20, 2025
…msRequest` RPC (#103784) Another follow-up to #102808. Fixes [SENTRY-5DCB](https://sentry.sentry.io/issues/7049009648?project=1). The `trace_item_type` field must be passed in both the `TraceItemFilterWithType` and `RequestMeta` when issuing a `DeleteTraceItemsRequest` RPC. Previously, we were including this only in the `TraceItemFilterWithType`.
shashjar
added a commit
that referenced
this pull request
Nov 21, 2025
…quest` RPCs (#103848) Yet another follow-up to #102808. Resolves [SENTRY-5DCB](https://sentry.sentry.io/issues/7049009648?project=1). Resolves [SENTRY-5DCN](https://sentry.sentry.io/issues/7049508299?project=1). The `EndpointDeleteTraceItems` implementation pulls `project_ids` out of the `RequestMeta`, so this field should not be included in the filters. The only filter condition we need to provide is a `ComparisonFilter.OP_IN` for the group IDs we are trying to delete for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #101385 / ID-997.
Resolves ID-1108.
The
DeleteTraceItemsendpoint (protobuf definition) is currently a no-op for deletion-by-attribute (getsentry/snuba#7535), so we're flipping deletion on by default. Theeventstream.eap.deletion-enabledoption provides a killswitch in case we need it.