fix(timeseries): Add a check that the other series has data#101476
Merged
Conversation
- There was seemingly a mismatch of stats vs timeseries behaviour when the groupby value was None, this adds a test to confirm that timeseries is behaving as expected
- This adds a check if the other series has data before adding it - I'm HOPING this will fix a prod vs local diff where production still returns the other series even when it doesn't have data
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101476 +/- ##
===========================================
+ Coverage 80.42% 80.81% +0.39%
===========================================
Files 8701 8709 +8
Lines 386148 388101 +1953
Branches 24409 24409
===========================================
+ Hits 310546 313649 +3103
+ Misses 75251 74101 -1150
Partials 351 351 |
wmak
changed the title
shruthilayaj
approved these changes
Oct 16, 2025
| if row[axis] and row[axis] != 0: | ||
| return True | ||
| return False | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: Timeseries Data Missing Expected Axis
In check_timeseries_has_data, accessing row[axis] directly can raise a KeyError if a row in the timeseries data is missing an expected axis from the y_axes list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.