fix(replay): Adding Safety Checking for Parse Tap Event#101532
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| payload_data = payload["data"] | ||
| payload_data = payload.get("data", {}) | ||
| return TapEvent( | ||
| timestamp=int(payload["timestamp"]), |
Contributor
There was a problem hiding this comment.
Bug: Inconsistent Field Access Causes KeyError
The parse_tap_event function inconsistently accesses the timestamp field directly, unlike other fields that now use .get() with defaults. This can raise a KeyError if timestamp is missing from events, potentially causing crashes and defeating the purpose of the added safety checks.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101532 +/- ##
===========================================
- Coverage 80.97% 80.97% -0.01%
===========================================
Files 8706 8706
Lines 386874 386874
Branches 24516 24516
===========================================
- Hits 313287 313284 -3
- Misses 73236 73239 +3
Partials 351 351 |
cmanallen
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous event_parser changes implements a new parse_tap_event function which creates a TapEvent based from the SDK. However, it seems like some outdated events are missing fields resulting in: