fix(logs): fix(logs): Logs are not grouped in the chart#101569
Closed
gggritso wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| yAxis: ts.groupBy.map(groupBy => groupBy.value).join(','), | ||
| groupBy: null, | ||
| }; | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: Empty GroupBy Array Overwrites YAxis
The swapGroupByAndYAxis function incorrectly processes ts.groupBy when it's an empty array. The if (!ts.groupBy) check doesn't account for empty arrays, causing the original yAxis to be overwritten with an empty string. This can break downstream logic expecting meaningful yAxis data.
k-fish
added a commit
that referenced
this pull request
Oct 16, 2025
This fixes chart grouping, instead of temporarily supporting the old way of `yAxis`, this attempts to support group-bys properly (see #101569)
Member
Author
|
Obviated by #101626 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke this in #100532, which changed the
yAxisvalue of theTimeSeriesobject to be correct.useStreamingTimeSeriesResultrelies on the old format, though, where theyAxiscontains the name of the group! This PR is a hotfix while we think of a better solution. It effectively reverts to the old data structure just for logs, so streaming can continue to work.