Skip to content

fix(prevent): Allow members to update config#101767

Closed
suejung-sentry wants to merge 2 commits into
masterfrom
sshin/prevent/config-perm
Closed

fix(prevent): Allow members to update config#101767
suejung-sentry wants to merge 2 commits into
masterfrom
sshin/prevent/config-perm

Conversation

@suejung-sentry

Copy link
Copy Markdown
Contributor

We got feedback that we want members to be allowed to update config for the PR Review in order to change the type and frequency of reviews. Since this is in beta, there are no billing implications (where a member can create much higher usage that would then get billed). This is aligned with like Seer project settings and Github Integrations settings which allows members to edit.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 17, 2025
Comment thread src/sentry/prevent/endpoints/pr_review_config.py Fixed
@codecov

codecov Bot commented Oct 18, 2025

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
41201 1 41200 250
View the top 1 failed test(s) by shortest run time
tests.sentry.prevent.endpoints.test_pr_review_config.OrganizationPreventGitHubConfigTest::test_invalid_config_schema_returns_400
Stack Traces | 2.52s run time
#x1B[1m#x1B[.../prevent/endpoints/test_pr_review_config.py#x1B[0m:53: in test_invalid_config_schema_returns_400
    assert "'github_organizations' is a required property" in resp.data["detail"]
#x1B[1m#x1B[31mE   assert "'github_organizations' is a required property" in 'Invalid config'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@getsantry

getsantry Bot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Nov 8, 2025
@suejung-sentry suejung-sentry deleted the sshin/prevent/config-perm branch November 12, 2025 18:57
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants